fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION objectType fix #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christosarvanitis
force-pushed
the
fixGCStoSQLMigrator
branch
from
9d774fe to
c700331
Compare
christosarvanitis
force-pushed
the
fixGCStoSQLMigrator
branch
from
02aac6c to
535aa7a
Compare
|
@dbyron-sf / @ovidiupopa07 this is ready for review when you get a sec! Thanks! |
ovidiupopa07
approved these changes
Jun 9, 2024
jasonmcintosh
approved these changes
Jun 10, 2024
|
@jasonmcintosh would you consider backporting this fix? |
|
Yeah given that migration is completely broken for GCS to SQL... I'm good with this. @Mergifyio backport release-1.30.x release-1.31.x release-1.32.x release-1.33.x release-1.34.x |
|
https://github.com/Mergifyio backport release-1.30.x release-1.31.x release-1.32.x release-1.33.x release-1.34.x |
✅ Backports have been created
|
This was referenced Jun 11, 2024
Merged
Merged
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…fix (#1466) (#1470) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…fix (#1466) (#1471) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…fix (#1466) (#1473) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…fix (#1466) (#1472) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jun 18, 2024
…fix (#1466) (#1474) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
aman-agrawal
pushed a commit
to aman-agrawal/front50
that referenced
this pull request
Jul 5, 2024
…fix (spinnaker#1466) (spinnaker#1473) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
aman-agrawal
pushed a commit
to OpsMx/front50-oes
that referenced
this pull request
Jul 5, 2024
…fix (spinnaker#1466) (spinnaker#1473) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor (cherry picked from commit 3ab3bfc) Co-authored-by: Christos Arvanitis <[email protected]>
This was referenced Aug 21, 2024
This was referenced Aug 23, 2024
Merged
Merged
Merged
dbyron-sf
added
target-release/1.34
target-release/1.35
and removed
target-release/1.34
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was not correctly distinguishing between APPLICATION and APPLICATION_PERMISSION metadata leading to a migrator deserialisation issue for GCS to SQL Front50 migration.
This PR fixes this with a small refactor.
Fixes spinnaker/spinnaker#6957