Laiacano/java extract subsettings #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
approved these changes
Jul 30, 2018
|
@alaiacano tests failing, |
added 2 commits
July 30, 2018 16:01
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
+ Coverage 98.5% 98.5% +<.01%
=========================================
Files 54 54
Lines 1668 1677 +9
Branches 113 128 +15
=========================================
+ Hits 1643 1652 +9
Misses 25 25
Continue to review full report at Codecov.
|
regadas
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add Java bindings to the library, in order to access extractWithSubsetSettings functions from Java.