This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Add a unit file to manage helios-agent service #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnworb
reviewed
Jan 10, 2019
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I think it would be good to add some comments here about why we had to add this wrapper script (since the EnvironmentFile etc directives in the unit file don't support running arbitrary shell scripts)
mattnworb
reviewed
Jan 10, 2019
| @@ -0,0 +1,9 @@ | |||
| [Unit] | |||
| Description=Helios agent daemon | |||
There was a problem hiding this comment.
I think we also want to add a After=network.target to this section to signal that this service should be started after the network is available
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
============================================
- Coverage 52.95% 52.89% -0.07%
+ Complexity 1646 1645 -1
============================================
Files 268 268
Lines 13104 13104
Branches 1499 1499
============================================
- Hits 6939 6931 -8
- Misses 5652 5657 +5
- Partials 513 516 +3 |
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
============================================
- Coverage 52.95% 52.93% -0.03%
Complexity 1646 1646
============================================
Files 268 268
Lines 13104 13104
Branches 1499 1499
============================================
- Hits 6939 6936 -3
- Misses 5652 5655 +3
Partials 513 513 |
This sets up helios-agent to be configured as a daemon and managed via systemd Change unit file install path Add comment to wrapper script Add `After` directive to unit file
vbhavsar
force-pushed
the
vishal/systemd
branch
from
1b11bd8 to
6748262
Compare
mattnworb
approved these changes
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up helios-agent to be configured as a daemon and managed via systemd.
@mattnworb