Upgrade to Beam 2.63.0 #5613
Merged
Upgrade to Beam 2.63.0 #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
commented
Feb 19, 2025
Comment on lines
191
to
206
| it should "write case classes using Storage Write API" in { | ||
| runWithRealContext(options) { sc => | ||
| sc.parallelize(records) | ||
| .saveAsTypedBigQueryTable( | ||
| typedTableStorage, | ||
| createDisposition = CREATE_IF_NEEDED, | ||
| method = WriteMethod.STORAGE_WRITE_API | ||
| ) | ||
| }.waitUntilFinish() | ||
|
|
||
| runWithRealContext(options) { sc => | ||
| val data = sc.typedBigQuery[Record](typedTableStorage) | ||
| data should containInAnyOrder(records) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Both of these tests are failing. LocalTime fields are being written incorrectly using the Storage Write API. For example, for the same record, FileLoads will write the value 19:00:00 and StorageWrite will write the value 15:59:15.338944. Not quite sure what's going on, needs investigation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5613 +/- ##
==========================================
- Coverage 61.37% 61.33% -0.04%
==========================================
Files 314 314
Lines 11243 11255 +12
Branches 788 802 +14
==========================================
+ Hits 6900 6903 +3
- Misses 4343 4352 +9 ☔ View full report in Codecov by Sentry. |
kellen
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains bugfixes for BQ Storage-API writes and BQ Avro-format reads.