Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Update docs and more tests #1049

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Update docs and more tests #1049

merged 4 commits into from
Mar 7, 2023

Conversation

sonjaer
Copy link
Contributor

@sonjaer sonjaer commented Mar 7, 2023

Hey, I just made a Pull Request!

Update docs and more tests after #1041

Description

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@sonjaer sonjaer changed the title Add docs and more tests Update docs and more tests Mar 7, 2023
@sonjaer sonjaer changed the base branch from master to refactor-timeout-config March 7, 2023 16:03
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1049 (46dffe8) into master (04bf5b3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1049      +/-   ##
============================================
+ Coverage     92.28%   92.31%   +0.03%     
- Complexity     2138     2143       +5     
============================================
  Files           200      200              
  Lines          8282     8293      +11     
  Branches        502      502              
============================================
+ Hits           7643     7656      +13     
+ Misses          523      522       -1     
+ Partials        116      115       -1     

Base automatically changed from refactor-timeout-config to master March 7, 2023 16:26
@sonjaer sonjaer marked this pull request as ready for review March 7, 2023 16:27
@sonjaer sonjaer force-pushed the add-docs-and-more-tests branch from d0c1118 to 46dffe8 Compare March 7, 2023 16:34
@sonjaer sonjaer merged commit 4bd7c7f into master Mar 7, 2023
@sonjaer sonjaer deleted the add-docs-and-more-tests branch March 7, 2023 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants