Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add param to endpoint #1065

Merged
merged 13 commits into from
Apr 12, 2023
Merged

Add param to endpoint #1065

merged 13 commits into from
Apr 12, 2023

Conversation

sonjaer
Copy link
Contributor

@sonjaer sonjaer commented Mar 26, 2023

Hey, I just made a Pull Request!

Reverts/changes #1056

Description

There are two endpoints now:

  • /workflows/full
  • /workflows/

If a component is named full it would collide with the endpoint getting workflow states. This PR changes the path of the endpoint to be:

  • /workflows?full=true

Alt

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #1065 (d5a3eb7) into master (f2960de) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head d5a3eb7 differs from pull request most recent head 41a0fe0. Consider uploading reports for the commit 41a0fe0 to get more accurate results

@@             Coverage Diff              @@
##             master    #1065      +/-   ##
============================================
+ Coverage     92.30%   92.41%   +0.10%     
  Complexity     2150     2150              
============================================
  Files           200      200              
  Lines          8314     8314              
  Branches        502      503       +1     
============================================
+ Hits           7674     7683       +9     
+ Misses          526      517       -9     
  Partials        114      114              

@sonjaer sonjaer merged commit c372c61 into master Apr 12, 2023
@sonjaer sonjaer deleted the add-param-to-endpoint branch April 12, 2023 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants