This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Close okhttp response for requests we don't expect response body payload.
Motivation and Context
An OKHttp response must be closed (as explained here). For those requests we expect body payload, we read the body stream which results in
close
automatically, but for those we don't expect response body payload, currently we are not closing the response, which for some condition results in leaving threads hanging around.Have you tested this? If so, how?
Existing tests.
Checklist for PR author(s)
Checklist for PR reviewer(s)