This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Workaround flyte dynamic task error code propagation #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean error codes in the flyte event translator to replace the RetriesExhaused| prefix that comes with all dynamic node failures and retriable nodes
Add tests to ensure that error codes with the retries exhaused prefix are matching the expected error code
12 tasks
RRap0so
approved these changes
Jun 2, 2023
sonjaer
changed the title
andresgomezfrr
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Add a step to clean error codes in the FlyteEventTranslator class of the RetriesExhaused prefix.
Note that this is a temporary fix in the meantime the flyte folks while they fix a bug about how the dynamic tasks reports the errors. PR:flyteorg/flytepropeller#567
Motivation and Context
fixes #1083
Have you tested this? If so, how?
Added Tests to the FlyteEventTranslator test case to include one item for each scenario with the added prefix to ensure that the code is behaving as expected
Checklist for PR author(s)
Checklist for PR reviewer(s)