Remove unused code branch In GitCredentialsProviderFactory #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
reviewed
Dec 13, 2024
| @@ -92,13 +92,6 @@ else if (hasText(username)) { | |||
| this.logger.debug("Constructing UsernamePasswordCredentialsProvider for URI " + uri); | |||
| provider = new UsernamePasswordCredentialsProvider(username, password.toCharArray()); | |||
| } | |||
| else if (hasText(username) && !hasText(passphrase)) { | |||
There was a problem hiding this comment.
Maybe it shouldn't be removed and add && hasText(password) to the branch above? That will fix a potential NPE there anyway.
There was a problem hiding this comment.
@spencergibb This logic is tasting if passphrase has text not password. I agree that we should add a null check for password above. But we probably don't want to use a hasText check since having an empty string for password is valid (we have a test for that).
ryanjbaxter
force-pushed
the
gitcredentialsprovider-logic-has-username-no-password
branch
from
eb6da89 to
b502276
Compare
spencergibb
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2674