TestcontainersLifecycleBeanPostProcessor does not work correctly with scoped beans

[eddumelendez]

I’ve been playing around with several examples using Spring Boot Testcontainers at Development time and last night I noticed those are not working as expected with @RestartScope. IIRC this example used to work in the past, download the image, start the container and so on. I also tried something similar to what’s mentioned in the docs but the image is not downloaded at all in this example if @ServiceConnection is removed. It works as expected without @RestartScope

[nedimAT]

Hello @philwebb, i would like to fix this. Please assign it to me.

[philwebb]

Thanks @nedimAT, I've assigned the issue to you. I've no idea if it's an easy or difficult fix so feel free to comment here if you don't get anywhere.

[nedimAT]

Hello @eddumelendez, for me the rabbitmq example works as expected. Removing the @ServiceConnection Annotation means you have to setup the properties yourself, see docs dynamic-properties
The Pulsar example i can not get to run on my machine, caused by this bug
Can you provide further information about your issue and probably some logs? Your logs should contain some insights about what testcontainers is up to, similar to the following tc.rabbitmq:3.11-alpine : Pulling docker image: rabbitmq:3.11-alpine. Please be patient; this may take some time but only needs to be done once.

[eddumelendez]

I have another example. See https://github.com/eddumelendez/spring-boot-sqs-testcontainers-reusable-mode

In summary, @RestartScope works with existing supported ServiceConnections but not when used along with DynamicProperties. Not close at the computer right now but in those scenarios is like Testcontainers is ignored and not picked up. You should be able to reproduce with this last example. If needed I can attach logs later.

[nedimAT]

Thanks, with that example i can reproduce it. I will start looking into it.

[nedimAT]

Hello @philwebb could you provide me with some hint where i should start. What i know so far is, that @RestartScope on its own is not enough for the Container to be started. One needs additionally @Scope or @ServiceConnection, but then the Container will restart with the Application. I searched now for some time in the DefaultListableBeanFactory for clues but i think i am stuck.

[eddumelendez]

I did another check and wonder if just changing the following lines

spring-boot/spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/lifecycle/TestcontainersLifecycleBeanPostProcessor.java

Lines 84 to 85 in b8c4fb6

	beanNames.addAll(List.of(this.beanFactory.getBeanNamesForType(ContainerState.class, false, false)));
	beanNames.addAll(List.of(this.beanFactory.getBeanNamesForType(Startable.class, false, false)));

to

beanNames.addAll(List.of(this.beanFactory.getBeanNamesForType(ContainerState.class, true, false)));
beanNames.addAll(List.of(this.beanFactory.getBeanNamesForType(Startable.class, true, false)));

due to the scope is not singleton anymore but restart.

[Wzy19930507]

I have another example. See https://github.com/eddumelendez/spring-boot-sqs-testcontainers-reusable-mode

Hi, @eddumelendez, @philwebb
this example is DynamicPropertyRegistry at Development Time is not working with @RestartScope.
DynamicPropertyRegistry need init property before SqsAsyncClient.

But when add @RestartScope, scope change to restart and skip code DefaultListableBeanFactory.preInstantiateSingletons
, so DynamicPropertyRegistry init property after SqsAsyncClient.

Is it reasonable to add a tip to the documentation?

[philwebb]

Thanks for the hint @eddumelendez. Hopefully fixed in the next snapshot.

[eddumelendez]

Thanks @philwebb ! It's working :)

[shawnweeks]

I've been following this ticket since before it got renamed and with the latest 3.3.2-SNAPSHOT The combination of @RestartScope and DynamicPropertyRegistry does work on startup but all the properties get unset after dev-tools reloads the app. Previously the properties didn't get set at all so it's definitely an improvement but I'm not sure this fully fixes the issue.

[scottfrederick]

@shawnweeks Does the discussion in #35200 and the documentation changes made in this related commit help with your use case?

[shawnweeks]

@scottfrederick They don't appear to. This issue was originally about Contributing Dynamic Properties at Development Time is not working with @RestartScope which is what still doesn't seem to be working. This issue seems to resolve part of the original issue but dynamic properties still don't fully work with RestartScope. Don't mind starting another ticket just don't want it to get closed as duplicate since this ticket appeared to be trying to resolve the same issue.