Add mDoc reader functions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
rschulman
reviewed
Aug 12, 2024
Ryanmtate
force-pushed
the
skit-233-iso-mdl-reader-interface-in-rust
branch
from
b2c7823 to
fc1fe25
Compare
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
The BLE ident isn't currently verified (an issue already exists) so it didn't break anything. Was unable to double-check with a non-mobile-sdk wallet.
Also re-add e2e test which had disappeared
cobward
approved these changes
Sep 3, 2024
src/mdl/reader.rs
Outdated
Comment on lines
125
to
130
| // TODO what was this for? Reusing the same reader? | ||
| #[derive(thiserror::Error, uniffi::Error, Debug)] | ||
| pub enum MDLReaderRequestBuildError { | ||
| #[error("{value}")] | ||
| Generic { value: String }, | ||
| } |
There was a problem hiding this comment.
Either remove the comment or the enum?
There was a problem hiding this comment.
removed the whole thing as it's unused
src/mdl/reader.rs
Outdated
Comment on lines
194
to
197
| // Bytes(Vec<u8>), // already converted in string | ||
| ItemMap(HashMap<String, MDocItem>), | ||
| Array(Vec<MDocItem>), | ||
| // Image(Vec<u8>) maybe? |
You would typically recreate a new flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
ble_identis correct. But probably not because we go from bytes to hex string back to bytes without decoding the string.MDocItemtype work in Kotlin, or move back to JSON as it is the type returned byisomdl