PR: Update update_fa5 command to rename internal font names during update #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
ccordoba12
reviewed
Jan 25, 2019
There was a problem hiding this comment.
Thanks @darkvertex for this. I left a couple of comments to avoid the error introduced by this when calling setup.py.
ccordoba12
changed the title
|
@ccordoba12 I addressed your feedback. Tests are clearing now. Thanks for the review. |
ccordoba12
reviewed
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to prevent further mistakes, I took the core code from https://github.com/chrissimpkins/fontname.py and made it into a utility function that then renames "regular" and "solid" flavours of FA5 to prevent issues like #107 .
This means that the command technically introduces a requirement for the "fonttools" module. Since it is a "dev" command I did not include it in the setup.py's
install_requiresbut I did a lot of reading and it seems very tricky to declare the dependency for the command only. There's anextra_requiresthing but that only works for package "entry_points" (which we don't use.) If you know a better way, I'm all ears.For now, it'll raise an exception if the import fails.