Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add FontAwesome 6 icons (6.7.2) and change font update command #274

Merged
merged 1 commit into from
Feb 21, 2025
Merged

PR: Add FontAwesome 6 icons (6.7.2) and change font update command #274

merged 1 commit into from
Feb 21, 2025

Conversation

dalthviz
Copy link
Member

  • Adds FontAwesome 6 related assets (6.7.2)
  • Update FontAwesome 5 update command to now update the 6 version assets
  • Removes reference to FontAwesome 4 over docstrings

Fixes #230

@dalthviz dalthviz added this to the v1.4.0 milestone Feb 21, 2025
@dalthviz dalthviz self-assigned this Feb 21, 2025
@dalthviz dalthviz changed the title PR: Add FontAwesome 6 icons and change font update command PR: Add FontAwesome 6 icons (6.7.2) and change font update command Feb 21, 2025
@dalthviz dalthviz marked this pull request as ready for review February 21, 2025 00:37
@dalthviz dalthviz requested a review from ccordoba12 February 21, 2025 00:38
ccordoba12
ccordoba12 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 36de05f into spyder-ide:master Feb 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Add Font Awesome 6 and remove deprecated Font Awesome 4
2 participants
@dalthviz @ccordoba12