Add grammar for PostgreSQL GENERATED columns
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincianfarini
commented
Sep 25, 2021
core/src/main/kotlin/com/alecstrong/sql/psi/core/postgresql/PostgreSql.bnf
Outdated
Show resolved
Hide resolved
kevincianfarini
commented
Sep 25, 2021
AlecKazakova
approved these changes
Sep 27, 2021
core/src/main/kotlin/com/alecstrong/sql/psi/core/postgresql/PostgreSql.bnf
Outdated
Show resolved
Hide resolved
MariusVolkhart
added a commit
to MariusVolkhart/sql-psi
that referenced
this pull request
Feb 20, 2022
Both HSQLDB and H2 support both variants of this clause. See http://hsqldb.org/doc/2.0/guide/databaseobjects-chapt.html#dbc_tables and https://h2database.com/html/grammar.html#column_definition respectively. Support for this was previously implemented for Postgres in 52c847 (sqldelight#295).
AlecKazakova
pushed a commit
that referenced
this pull request
Feb 22, 2022
Both HSQLDB and H2 support both variants of this clause. See http://hsqldb.org/doc/2.0/guide/databaseobjects-chapt.html#dbc_tables and https://h2database.com/html/grammar.html#column_definition respectively. Support for this was previously implemented for Postgres in 52c847 (#295).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294