Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wildcard expressions #454

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Refactor wildcard expressions #454

merged 2 commits into from
Oct 2, 2020

Conversation

alanmcruickshank
Copy link
Member

Fixes #449 . This introduces a backward incompatible change to the handling of * segments but I think it's for the best.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #454 into master will increase coverage by 0.01%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   91.73%   91.74%   +0.01%     
==========================================
  Files          30       30              
  Lines        4633     4654      +21     
==========================================
+ Hits         4250     4270      +20     
- Misses        383      384       +1     
Flag Coverage Δ
#py35 91.61% <97.36%> (+0.01%) ⬆️
#py36 91.61% <97.36%> (+0.01%) ⬆️
#py37 91.61% <97.36%> (+0.01%) ⬆️
#py38 91.56% <97.43%> (+0.01%) ⬆️
#py39 91.56% <97.43%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlfluff/rules/std.py 93.67% <87.50%> (-0.15%) ⬇️
src/sqlfluff/dialects/dialect_ansi.py 99.64% <100.00%> (+0.02%) ⬆️
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <100.00%> (ø)
src/sqlfluff/parser/segments_base.py 88.21% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc93ee2...0afe5b1. Read the comment docs.

@alanmcruickshank alanmcruickshank merged commit 7d68d01 into master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L013 and L025 bug
2 participants