Always generate provider factories for binding modules #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
force-pushed
the
rick/factory-generation-mess
branch
from
91cb4fa to
98c19cf
Compare
RBusarow
changed the title
fixes #948 If full Dagger factory generation is happening in any way (via Anvil, Dagger with KSP, or Dagger with KAPT), then behavior doesn't change. If none of those factory sources are happening in a target compilation, and that compilation is creating a binding module with a `@Provides` function (for an `object`), then the `Contribution` will take it upon itself to generate the factory. We determine if the Dagger generation is happening by inspecting the dependencies in the kapt/ksp plugin classpaths.
RBusarow
force-pushed
the
rick/factory-generation-mess
branch
from
98c19cf to
d199e76
Compare
JoelWilcox
approved these changes
Apr 9, 2024
compiler/src/main/java/com/squareup/anvil/compiler/AnvilCommandLineProcessor.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #948
If full Dagger factory generation is happening in any way (via Anvil, Dagger with KSP, or Dagger with KAPT), then behavior doesn't change.
If none of those factory sources are happening in a target compilation, and that compilation is creating a binding module with a
@Providesfunction (for anobject), then theContributionwill take it upon itself to generate the factory.We determine if the Dagger generation is happening by inspecting the dependencies in the kapt/ksp plugin classpaths.