Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified get_filenames_from_dir to exclude .DS_Store files #82

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

sahiljani
Copy link
Contributor

Pull Request Title

Exclude .DS_Store Files in get_filenames_from_dir Function

Related Issue

N/A

Description

Updated the get_filenames_from_dir function to exclude .DS_Store files, providing a cleaner output list of filenames.

Type

  • [x ] Bug Fix
  • [] Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • Updated the get_filenames_from_dir function to ignore .DS_Store files in the directory being read.

Screenshots / Code Snippets (if applicable)

N/A

How to Test

  1. Call the get_filenames_from_dir function with a directory that includes .DS_Store file.
  2. Check the output list of filenames to verify that .DS_Store file is not included.

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • [] The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

No additional information.

Copy link
Owner

@srbhr srbhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think someone else also faced a similar problem thanks for sorting it out @sahiljani
Approved.

@srbhr srbhr merged commit 3f3d467 into srbhr:main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants