Fix sscpac/chat-locker#14. user search not returning users. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RocketChat searches the users collection on the 'name' field. however, we didn't set the value when importing ldap. Updated directoryservice to set the name field using ldap username.
ldap's givenName and sn fields. - Replaced confusing field mapping with functions that directly convert an LDAP entry to an Rocket.Chat user object. - Set name field to use ldap's given name and sn fields, and also set in profile.first_name and profile.last_name to aid in search by first or last name.
rwakida
force-pushed
the
bugfix/chat-locker-14
branch
from
a43483c to
ae3df35
Compare
|
Looks good to me. I like the refactor and commenting for the LDAP attribute mapping code - much cleaner and easier to read. After deploying, I see the "name" field populated, and it gets appropriately pulled when I perform a user search inside the app. |
rwakida
added a commit
that referenced
this pull request
Jul 29, 2015
Fix #14. user search not returning users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocketChat searches the users collection on the 'name' field. however, we
didn't set the value when importing ldap. Updated directoryservice to
set the name field using ldap username.