Integrate LDAP into RocketChat #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses proprietary LDAP classes that retrieve user data from LDAP. Eventually need to replace with rocketchat-ldap code once it matures. - Registers login handler that authenticates againist LDAP - Import defeault settings that contains LDAP configuration.
RocketChat adds new users to the GENERAL channel as part of the registration process (when setting username). Unfortunately, we pre-load the users from LDAP and do not allow them to set their username which skips the code that adds them to GENERAL channel. Thus, we need to add them to the GENERAL channel when we pre-load the users. Also, we can't re-use RocketChat's code because their method assumes that a user is logged in, but our code is run at startup and has no user.
login. User information is pre-loaded at startup and refreshed at login. However, the upsert method overwrote the user object instead of individual fields. This was evident after the intial login. The initial login correctly asked for an avatar and set a corresponding field. However, on subsequent logins, the user was prompted for an avatar again because the ldap values overwrote the user and deleted the avatar field.
|
Code looks good, though I didn't really go over the stuff that was copy-pasted from the old chat app. Maybe in the future we can put the code for adding users to the "General" channel into a separate method so that we don't duplicate between the "setUsername" method and the "addUsersToRoom" function. Ran the app and tested for a while. I can log in with any of our LDAP users, and looking at the users collection, it looks like all of the attributes are there, including the security permission labels. I approve the pull request. |
rwakida
added a commit
that referenced
this pull request
Jul 16, 2015
Integrate LDAP into RocketChat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated previous project code related to LDAP access (login, get values) with RocketChat. You should be able to login using ldap username/password values and participate in all RocketChat channels and direct messaging.