Use existing formats for saved filters #5697
Merged
+218
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feederbox826
reviewed
Mar 3, 2025
There was a problem hiding this comment.
everything works but DateCriterionOptions. It clones it with
date:
modifier: "BETWEEN",
value: {
value: "2025-01-01"
value2: "2025-01-02"
}
}and similarly for single value
This occurs not on saving but when selecting the filter by itself. It is saved in this format as well. Hopefully this is as simple as removing the class overrides (looking at public cloneValues())
|
👀 pulling, building and testing now |
feederbox826
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5632 introduced some changes around the format of the saved filters that wasn't fully ready. This existing saved filter format is currently not correct. It's supposed to follow the format of the graphql filter inputs, but instead it's following the schema of the UI object model. Fixing that issue will require a migration to massage the saved filter formats. This PR rolls back the changes to the saved filter format.
Note that this will not fix corrupted saved filters created after the #5632 build.
Resolves #5690