createSkyInspector #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellson
commented
Jan 26, 2024
| @@ -30,7 +34,8 @@ | |||
| "prepublishOnly": "tsup src/index.ts --dts", | |||
| "changeset": "changeset", | |||
| "release": "changeset publish", | |||
| "version": "changeset version" | |||
| "version": "changeset version", | |||
| "dev": "yarn build && ./scripts/dev.sh" | |||
There was a problem hiding this comment.
The dev script will build and copy the package to destinations defined in a root .env file. Let's say you wanted to try this package in two other projects (studio and sky-starter-app) located in the same directory as inspect. Then you would add this to your .env file:
DEV_DESTINATIONS="../sky-starter-app,../studio"
davidkpiano
reviewed
Jan 26, 2024
davidkpiano
reviewed
Jan 26, 2024
src/createSkyInspector.ts
Outdated
| serialize(event) { | ||
| if (!filter || filter(event)) { | ||
| const skyEvent = apiKey ? { apiKey, ...event } : event; | ||
| socket.send(stringify(skyEvent)); |
There was a problem hiding this comment.
This is in the wrong place - we should repurpose createWebsocketInspector for this
(I say "wrong" because this option is only meant for serializing the event; it should be pure)
There was a problem hiding this comment.
Makes sense; this was just me exploiting what I had available 😅 I've tried to update the browser inspector to match what we need in the latest; see if this looks okay to you.
Co-authored-by: David Khourshid <[email protected]>
davidkpiano
approved these changes
Feb 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
createSkyInspector, which allows you to inspect machines in Node or the browser. The inspection will send the events to a server backend through websockets and allows you to open and share a live inspection URL.