published ENRs do not contain the UDP port

[kaiserd]

The ENRs made available in #42 do not contain the UDP port.
The cause might be that discv5 is not enabled on the fleet nodes. If --discv5-discovery=false, which is the default, only DNS related ENRs are available.

Currently, nwaku manages two separate ENRs, see waku-org/nwaku#915
The json RPC call returns the discv5 related ENR; only if discv5 is disabled, it will return the DNS related ENR.

cc @jakubgs @jm-clius

(Further, only the jenkins pipeline for the status-test fleet has the -d:discv5_protocol_id:d5waku. This unrelated to this issue, but necessary for Waku discv5 operation. The other fleets would need that parameter set, too)

[jakubgs]

Indeed, we do not have it enabled:

 > a all -a 'grep discv5-discovery /docker/nim-waku-v2/docker-compose.yml'
node-01.do-ams3.wakuv2.test | FAILED | rc=1 >>
non-zero return code
node-01.gc-us-central1-a.wakuv2.test | FAILED | rc=1 >>
non-zero return code
node-01.ac-cn-hongkong-c.wakuv2.test | FAILED | rc=1 >>
non-zero return cod

[jakubgs]

Done: e4642a51

 > a all -a 'grep discv5-discovery /docker/nim-waku-v2/docker-compose.yml'
node-01.do-ams3.wakuv2.test | CHANGED | rc=0 >>
      --discv5-discovery=true
node-01.gc-us-central1-a.wakuv2.test | CHANGED | rc=0 >>
      --discv5-discovery=true
node-01.ac-cn-hongkong-c.wakuv2.test | CHANGED | rc=0 >>
      --discv5-discovery=true

 > a all -a 'grep discv5-discovery /docker/nim-waku-v2/docker-compose.yml'
node-01.do-ams3.wakuv2.prod | CHANGED | rc=0 >>
      --discv5-discovery=true
node-01.gc-us-central1-a.wakuv2.prod | CHANGED | rc=0 >>
      --discv5-discovery=true
node-01.ac-cn-hongkong-c.wakuv2.prod | CHANGED | rc=0 >>
      --discv5-discovery=true

[jakubgs]

We can see here how the ENR record changed:

Before

 > nimbus_beacon_node record print enr:-Mi4QLr6Xdnrzp3imebRPr8LXuUKWablTwnXLzxGi5Q47-lYMwf4zPeGcfLy9IXXdT-PwXXv96eBS8ZunmaFlUKJ81cBgmlkgnY0gmlwhLymh5GKbXVsdGlhZGRyc7EALzYobm9kZS0wMS5kby1hbXMzLndha3V2Mi5wcm9kLnN0YXR1c2ltLm5ldAYfQN4DiXNlY3AyNTZrMaEDbl1X_zJIw3EAJGtmHMVn4Z2xhpSoUaP5ElsHKCv7hlWDdGNwgnZfhXdha3UyDw
(1, id: "v4", ip: 188.166.135.145, multiaddrs: 0x002F36286E6F64652D30312E646F2D616D73332E77616B7576322E70726F642E737461747573696D2E6E6574061F40DE03, secp256k1: 0x036E5D57FF3248C37100246B661CC567E19DB18694A851A3F9125B07282BFB8655, tcp: 30303, waku2: 0x0F)

After

 > nimbus_beacon_node record print enr:-JK4QIJuHZHTCaUOOwupvl7e3K1DyeDI6a609YJKdlovKj0pQa66P-2lMCw5oYUD-veYl0NNLW2CYHLYrC9CmZqDTLEBgmlkgnY0gmlwhLymh5GJc2VjcDI1NmsxoQNuXVf_MkjDcQAka2YcxWfhnbGGlKhRo_kSWwcoK_uGVYN0Y3CCdl-DdWRwgiMohXdha3UyDw
(1, id: "v4", ip: 188.166.135.145, secp256k1: 0x036E5D57FF3248C37100246B661CC567E19DB18694A851A3F9125B07282BFB8655, tcp: 30303, udp: 9000, waku2: 0x0F)

The multiaddrs field is gone, but the udp field is present.

[jakubgs]

 > c fleets.status.im | jq '.fleets."status.test"."enr/p2p/waku"'
{
  "node-01.ac-cn-hongkong-c.status.test": "enr:-JK4QAi2yenhIbflVpUtkLDAM7yR5qeinZSQ_TNxfAWxdffkQWlstXyspEUlapiLl-S_MTPyp5V1uiV14ATjcVU_iLoBgmlkgnY0gmlwhC_y6SSJc2VjcDI1NmsxoQJkb7I6j5X1-zjieMeBdxgDqQWuMuDUEqDR419lyKNZb4N0Y3CCdl-DdWRwgiMohXdha3UyDw",
  "node-01.do-ams3.status.test": "enr:-JK4QIGyJyjSlponBZqe9XZ75b5ePSU9fWw5UtxEF1vsYXTLYkTa4psnUxJPmOcJGVt9XCYpC2h2kNoowl1t5KzuW6wBgmlkgnY0gmlwhEDhUe2Jc2VjcDI1NmsxoQIE3HkSvDkl2zD64j2kGMH9XZHpuu-5VYT4wnBgJApW_oN0Y3CCdl-DdWRwgiMohXdha3UyDw",
  "node-01.gc-us-central1-a.status.test": "enr:-JK4QM2ylZVUhVPqXrqhWWi38V46bF2XZXPSHh_D7f2PmUHbIw-4DidCBnBnm-IbxtjXOFbdMMgpHUv4dYVH6TgnkucBgmlkgnY0gmlwhCJ6_HaJc2VjcDI1NmsxoQM06FsT6EJ57mzR_wiLu2Bz1dER2nUFSCpaXzCccQtnhYN0Y3CCdl-DdWRwgiMohXdha3UyDw"
}

[kaiserd]

Nice. Thank you :). LGTM! The ENRs on fleets.status.im show the discv5 ENR now.