re: Better Manage the Stats Set #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 14, 2013 17:38
We have to use before(:each) rather than before(:all), or our test doubles don't end up being properly configured(Get "unexpected message" errors for every example besides the first that uses redis). This also caught me by surprise, but the reference is here: https://github.com/rspec/rspec-mocks#use-beforeeach-not-beforeall
Now supports passing the amount of sample data to keep in Redis. The default is 180 samples, which at 10 seconds/sample is half an hour's worth of samples. The dashboard now uses this amount when starting up to determine how much data to request from the server. In addition, the worker will now clean up any excess samples from Redis. Clean up is currently done every time a sample is written(since Redis operations are cheap), but this could be done less frequently if necessary.
The end-user can now specify how long data should be kept. This also controls how much data is pulled for the chart. This should be a little more intuitive than specifying the number of samples to keep.
|
Thanks @dcartoon, I'll do a review in the next couple of days. |
|
Don't worry about it, I'll make the changes. Thanks for the contribution. |
steelThread
added a commit
that referenced
this pull request
May 22, 2013
re: Better Manage the Stats Set
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes should address this issue. It allows the user to specify data lifespan(in minutes, default: 30). The lifespan affects how much data is kept in Redis, and it also controls how much data is pulled for the memory chart.
Let me know what you think, I'm happy to make any changes.