Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql conditions to class level #296

Merged
merged 1 commit into from
Dec 30, 2016
Merged

sql conditions to class level #296

merged 1 commit into from
Dec 30, 2016

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented Oct 21, 2016 •
edited
Loading

Move conditions from instance methods to materialized views mixin.

The goal is two fold:

  • move scoping functionality out of the instance so many hierarchies can be fetched at once
  • all ancestry column manipulation is in one place.

/cc @Fryguy first was the main incentive for this PR. but running into the desire to be able to fetch a hierarchy without going into ruby is now pushing the second one hard. (that is why I just revisited / rebased)

@kbrock kbrock changed the title Base conditions sql conditions to class level Oct 21, 2016
@kbrock kbrock force-pushed the base_conditions branch 3 times, most recently from dc53945 to 4282f00 Compare October 25, 2016 21:05
@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 97.647% when pulling 4282f00 on kbrock:base_conditions into be6f04b on stefankroes:master.

@coveralls
Copy link

coveralls commented Dec 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 98.256% when pulling 30b14b8 on kbrock:base_conditions into 2a7a874 on stefankroes:master.

@kbrock kbrock mentioned this pull request Dec 22, 2016
Open
@coveralls
Copy link

coveralls commented Dec 28, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 98.551% when pulling 95f83fc on kbrock:base_conditions into 27a29f1 on stefankroes:master.

@kbrock kbrock merged commit efb603e into stefankroes:master Dec 30, 2016
@kbrock kbrock deleted the base_conditions branch December 30, 2016 15:15
@kbrock kbrock mentioned this pull request Mar 4, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrock @coveralls