Don't drop parentless nodes #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
consistent_sorting
branch
from
9f39f0a to
64ebdd7
Compare
|
👍 |
Fryguy
approved these changes
Nov 2, 2018
kbrock
force-pushed
the
consistent_sorting
branch
from
64ebdd7 to
329429d
Compare
With missing nodes that are used to sort, there ends up being some area of gray introduced CORRECT / STRICT concepts to allow tests to pass while the proper balance of priorities is introduced tests
calculating the depths is not necessary. Just checking parent nodes works well enough OrderedHash are no longer necessary NOTE: These tests were fixed by the trafium's commit
kbrock
force-pushed
the
consistent_sorting
branch
from
329429d to
aea6b73
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #415
Fixes #411
Fixes #362
arrange_nodesno longer drops child nodes. thanks @trafium@Fryguy Think this is the simplified version of 415 that you wanted
We also now have other tests showing what other work needs to be done