Add path_ids_in_database back #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was removed by 0fcd12f stefankroes#589 adding fields back. added tests to exercise
Change nav test to more clearly show what is being tested
assert_attributes really changed there are so many attributes to test for each node. It made the tests unreadable. This required changing the format of the parameters The matrix felt like a hack at first, but it is not programmatically testing stuff. there is a hardcoded list of what needs to be done for each node. Which in essence is what tests do. This is now properly testing all these attributes for in_database along the whole lifecycle of these objects
The destroy and the after save callbacks leverage the before_last_save methods. I had trouble testing those values outside callbacks, and in the callback, I didn't know the best way to assert values.
This was removed by stefankroes#589 Adding it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added path_ids_in_database back.
It was removed by mistake in #589
Fixes #645