Skip to content
This repository has been archived by the owner on Jun 4, 2023. It is now read-only.

Search for devices without logical grouping #122

Closed
wants to merge 1 commit into from
Closed

Search for devices without logical grouping #122

wants to merge 1 commit into from

Conversation

Mange
Copy link

@Mange Mange commented Mar 6, 2015

This should fix #31. I don't know why sonos.search and sonos.LogicalDevice are used in different places, but I can see that we don't seem to use the err parameter from the second variant, so no value seem to be lost to me.

Of course, just because it works in my setup does not guarantee that new problems aren't introduced. An alternative solution is to keep track of the IP + port pairs we've already set up and not do it more than once if we see any duplicates.

What do you think?

Tip: Append ?w=1 to the URL to see a diff that ignore whitespace changes.

@stephen
Copy link
Owner

stephen commented Mar 14, 2015

This removes group control capability from airsonos, which is not desirable. Am thinking your second solution likely makes more sense - keeping track of IP/ports to ignore duplicates brought up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airplay duplicating devices
2 participants