This repository has been archived by the owner on Jun 4, 2023. It is now read-only.
Search for devices without logical grouping #122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #31. I don't know why
sonos.search
andsonos.LogicalDevice
are used in different places, but I can see that we don't seem to use theerr
parameter from the second variant, so no value seem to be lost to me.Of course, just because it works in my setup does not guarantee that new problems aren't introduced. An alternative solution is to keep track of the IP + port pairs we've already set up and not do it more than once if we see any duplicates.
What do you think?
Tip: Append
?w=1
to the URL to see a diff that ignore whitespace changes.