Ignore tests that fail due to resource differences #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ignore annotation to tests that may fail due to differences in machine resources and can't be controlled via the tests
|
Starting 3-day comment window |
stleary
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Fixes #821
Add ignore annotation to tests that may fail due to differences in machine resources and can't be controlled via the test framework
Does the code still compile with Java6?
Yes
Risks
Small. If a change is made to the parser, it's possible that the test case that this is trying to solve for may break.
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
Does it break the unit tests?
No, it disables 2 tests that were expecting Stack Overflow errors, but would sometimes not trigger due to systems having differing resources available. The 2 tests were left intact, just marked with the
@Ignoreannotation.Was any code refactored in this commit?
No.
Review status
APPROVED