Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 #593

Closed
DandreChen opened this issue Sep 27, 2022 · 0 comments
Closed

feature(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 #593

DandreChen opened this issue Sep 27, 2022 · 0 comments
Assignees
@DandreChen
Labels
A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0
Milestone
StoneDB_8.0_v1.0.0

Comments

@DandreChen
Copy link
Collaborator

DandreChen commented Sep 27, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

from mysql/mysql_server:sql/sql_optimizer.cc
we can see the braces is deleted in the commit,But through this submission, we can find that another function is used instead of Query_block->braces

Describe the solution you'd like

adapt the code for MySQL 8.0

Describe alternatives you've considered

Additional context
@DandreChen DandreChen added the A-feature feature with good idea label Sep 27, 2022
@DandreChen DandreChen self-assigned this Sep 27, 2022
@DandreChen DandreChen changed the title feature(StoneDB 8.0): sl->braces is deleted by MySQL 8.0 feature(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0 Sep 27, 2022
@DandreChen DandreChen mentioned this issue Sep 28, 2022
Merged
14 tasks
DandreChen added a commit to DandreChen/stonedb that referenced this issue Sep 28, 2022
@DandreChen
feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0. (ston…
6f15a62 
…eatom#593)

[summary]
1 SELECT_LEX->braces is used in MySQL5.7, at optimize part, but deleted in MySQL 8.0
2 in MySQL 8.0, use Query_expression->is_union() instead of SELECT_LEX->braces
mergify bot pushed a commit that referenced this issue Sep 28, 2022
@DandreChen @mergify
feat(StoneDB 8.0): Query_block->braces is deleted by MySQL 8.0. (#593)
e38e73e 
[summary]
1 SELECT_LEX->braces is used in MySQL5.7, at optimize part, but deleted in MySQL 8.0
2 in MySQL 8.0, use Query_expression->is_union() instead of SELECT_LEX->braces
@RingsC RingsC added the C-stonedb-8.0 associated with stonedb 8.0 label Sep 28, 2022
@RingsC RingsC added this to the stonedb_8.0_v1.0.0 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DandreChen DandreChen

Labels
A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0
Projects
None yet
Milestone
StoneDB_8.0_v1.0.0
Development

No branches or pull requests
2 participants
@RingsC @DandreChen