Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: duplicate libreadline-dev install in workflow #687

Closed
2 of 3 tasks
hustjieke opened this issue Oct 11, 2022 · 1 comment
Closed
2 of 3 tasks

bug: duplicate libreadline-dev install in workflow #687

hustjieke opened this issue Oct 11, 2022 · 1 comment
Assignees
@hustjieke
Labels
A-bug Something isn't working C-stonedb-5.7 associated with stonedb 5.7 C-stonedb-8.0 associated with stonedb 8.0 good first issue Good for newcomers
Milestone
StoneDB_8.0_v1.0.0

Comments

@hustjieke
Copy link
Collaborator

Have you read the Contributing Guidelines on issues?

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Describe the problem

duplicate libreadline-dev installed in

      - name: install prerequisites
        run: |
          sudo apt-get update
          sudo apt-get install cmake make perl bison libaio-dev \
          openssl libssl-dev libncurses5-dev libreadline-dev \
          autoconf automake libtool \
          libreadline-dev libpam0g-dev zlib1g-dev libcurl-ocaml-dev \
          autotools-dev libicu-dev libboost-all-dev \
          libgflags-dev libsnappy-dev libbz2-dev liblz4-dev libzstd-dev libjemalloc-dev -y

both in
https://github.com/stoneatom/stonedb/blob/stonedb-8.0-dev/.github/workflows/integration-compile-mtryml#L44
https://github.com/stoneatom/stonedb/blob/stonedb-8.0-dev/.github/workflows/integration-compile-mtryml#L44

Expected behavior

Just install once.

How To Reproduce

No response

Environment

No response

Are you interested in submitting a PR to solve the problem?

  • Yes, I will!
@hustjieke hustjieke added A-bug Something isn't working good first issue Good for newcomers C-stonedb-5.7 associated with stonedb 5.7 C-stonedb-8.0 associated with stonedb 8.0 labels Oct 11, 2022
@hustjieke
Copy link
Collaborator Author

hustjieke commented Oct 11, 2022 •
edited
Loading

Impacted both on branch stonedb-5.7-dev and stonedb-8.0-dev

@hustjieke hustjieke added this to the stonedb_8.0_v1.0.0 milestone Oct 12, 2022
hustjieke added a commit to hustjieke/stonedb-8.0.30-upgrade that referenced this issue Nov 15, 2022
@hustjieke
fix(workflow): rm duplicate libreadline-dev in lib preparaion stoneat…
38b8e41 
…om#687
hustjieke added a commit to hustjieke/stonedb-8.0.30-upgrade that referenced this issue Nov 15, 2022
@hustjieke
fix(workflow): rm duplicate libreadline-dev in lib preparation stonea…
9c6e7c7 
…tom#687
@hustjieke hustjieke mentioned this issue Nov 15, 2022
Merged
15 tasks
mergify bot pushed a commit that referenced this issue Nov 16, 2022
@hustjieke @mergify
fix(workflow): rm duplicate libreadline-dev in lib preparation #687
c213415
mergify bot pushed a commit that referenced this issue Nov 17, 2022
@hustjieke @mergify
fix(workflow): rm duplicate libreadline-dev in lib preparaion #687
0f2fe68
Repository owner moved this from Todo to Done in StoneDB for MySQL 5.7 Nov 24, 2022
Repository owner moved this from Todo to Done in StoneDB for MySQL 8.0 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hustjieke hustjieke

Labels
A-bug Something isn't working C-stonedb-5.7 associated with stonedb 5.7 C-stonedb-8.0 associated with stonedb 8.0 good first issue Good for newcomers
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

No branches or pull requests
1 participant
@hustjieke