fix(tianmu): AUTO_INCREMENT of the Primary Key with tianmu occurs the problem of max value about data type(#1046) #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isredstar
added
A-bug
isredstar
requested review from
RingsC,
lujiashun,
hustjieke and
duanfuxiang0
and removed request for
RingsC and
lujiashun
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportBase: 42.73% // Head: 42.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1144 +/- ##
================================================
Coverage 42.73% 42.73%
================================================
Files 1830 1830
Lines 395970 395989 +19
================================================
+ Hits 169223 169233 +10
- Misses 226747 226756 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
RingsC
reviewed
Dec 18, 2022
RingsC
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #1046
Analysis: When the auto-increment obtained is greater than the maximum value of the data type, the inserted data will become negative. According to the debugging analysis of the code, it is found that the auto-increment maximum value obtained is not compared with the maximum value that the type can store, so the value overflow occurs.
Solution: Compare the type maximum value with auto-increment value. When the auto-increment value is less than the maximum value, it can be inserted normally. When the auto-increment value is is greater than the maximum value, it will report the error of primary key conflict.
main fix： if auto_inc_value < max_value, return auto_inc_value else return max_value，also consider the unsigned auto_increment column and primary key conflict.
Tests Check List
Changelog
Documentation