Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): add NO_KEY_ERROR to sql_mode for ignoring unsupported error.(#1318) #1320

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #1318

[summary]
Add NO_KEY_ERROR to sql_mode.
Add judgement for secondary index、unique index、trigger、etc.
Add test cases for NO_KEY_ERROR to test secondary index、unique index and trigger.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

…stoneatom#1318)

Add NO_KEY_ERROR to sql_mode.
Add judgement for secondary index、unique index、trigger、etc.
@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2023

This pull request's title should follow requirements next. @DandreChen please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@DandreChen DandreChen changed the title feat(sql):add NO_KEY_ERROR to sql_mode for ignoring unsupported error.(#1318) feat(sql): add NO_KEY_ERROR to sql_mode for ignoring unsupported error.(#1318) Feb 21, 2023
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 2 times, most recently from c3158dc to 4cf5b8b Compare February 21, 2023 08:53
@DandreChen DandreChen self-assigned this Feb 21, 2023
Add test cases for NO_KEY_ERROR to test secondary index、unique index and trigger.
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 43.11% // Head: 43.11% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f32d655) compared to base (dc2c64b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1320      +/-   ##
===================================================
- Coverage            43.11%   43.11%   -0.01%     
===================================================
  Files                 1830     1830              
  Lines               396374   396385      +11     
===================================================
+ Hits                170904   170908       +4     
- Misses              225470   225477       +7     
Impacted Files Coverage Δ
sql/sql_class.h 70.93% <ø> (ø)
sql/sys_vars.cc 16.62% <ø> (ø)
sql/auth/sql_authorization.cc 20.81% <100.00%> (+0.06%) ⬆️
sql/sql_table.cc 65.21% <100.00%> (+0.06%) ⬆️
sql/sql_trigger.cc 80.85% <100.00%> (+0.20%) ⬆️
storage/tianmu/handler/ha_tianmu.cpp 55.95% <100.00%> (+0.12%) ⬆️
storage/innobase/row/row0umod.cc 62.50% <0.00%> (-4.17%) ⬇️
storage/innobase/btr/btr0bulk.cc 80.89% <0.00%> (-0.96%) ⬇️
storage/myisam/mi_dynrec.c 57.47% <0.00%> (-0.87%) ⬇️
mysys/my_rdtsc.c 80.51% <0.00%> (-0.65%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 923c991 into stoneatom:stonedb-5.7-dev Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add sql_ mode parameter, which controls the error ignore of unsupported DLL
3 participants