-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tianmu): fix crash when the aggregated element was decimal (#1402) #1506
fix(tianmu): fix crash when the aggregated element was decimal (#1402) #1506
Conversation
This pull request's title should follow requirements next. @adofsauron please check it 👇. Valid format:
Valid types:
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1506 +/- ##
===================================================
- Coverage 44.91% 44.86% -0.05%
===================================================
Files 1999 1999
Lines 413910 413913 +3
===================================================
- Hits 185902 185712 -190
- Misses 228008 228201 +193
... and 92 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Fix the crash first 2. then redesign the entire aggregated data stream
Summary about this PR
Issue Number: close #1402
Tests Check List
Changelog
Documentation