fix(tianmu):The mysqld is crashed when you are starting replication.(#1523) #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1540 +/- ##
===================================================
+ Coverage 45.00% 45.05% +0.04%
===================================================
Files 1999 1999
Lines 413913 413901 -12
===================================================
+ Hits 186283 186484 +201
+ Misses 227630 227417 -213
... and 121 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…toneatom#1523) It is possible to update null values with null values in the delta layer, For example: update t set name="xiaohua" where id=1; update t set name=null where id=1; So when encountering this situation, directly return
konghaiya
requested review from
adofsauron,
RingsC,
wisehead,
hustjieke and
haitaoguan
haitaoguan
approved these changes
Apr 11, 2023
wisehead
reviewed
Apr 11, 2023
| Value row_val = row.second; | ||
| if (ct.Lookup() && row_val.HasValue()) { | ||
| auto &str = row_val.GetString(); | ||
| std::shared_ptr<Value> row_val = row.second; |
There was a problem hiding this comment.
why use shared_ptr here? please add some comments.
| @@ -1168,10 +1162,6 @@ void TianmuAttr::DeleteData(uint64_t row) { | |||
| CopyPackForWrite(pn); | |||
| auto &dpn = get_dpn(pn); | |||
| auto dpn_save = dpn; | |||
| if (dpn.Trivial()) { | |||
| @@ -209,30 +209,10 @@ class DelayedInsertParser final { | |||
| ptr += str_len; | |||
| } break; | |||
| case common::PackType::INT: { | |||
| if (attr->Type().Lookup()) { | |||
There was a problem hiding this comment.
why not check the Lookup() ?
adofsauron
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to update null values with null values in the delta layer, For example:
update t set name="xiaohua" where id=1;
update t set name=null where id=1;
So when encountering this situation, directly return
Summary about this PR
Issue Number: close #1523
Tests Check List
Changelog
Documentation