-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tianmu): fix specified key was too long; max key length is 255 bytes(#228) #475
Conversation
This pull request's title should follow requirements next. @lujiashun please check it 👇. Valid format:
Valid types:
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
…tes(stoneatom#228) (1). implement tianmu's virtual function max_supported_key_part_length; (2). enlarge max_supported_key_length's return value from 1024 to 16*1024;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix(tianmu): fix specified key was too long; max key length is 255 bytes(#228)
(1). implement tianmu's virtual function max_supported_key_part_length; (2). enlarge max_supported_key_length's return value from 1024 to 16*1024;
Summary about this PR
Issue Number: close #228
1、tianmu engine limit the max_supported_key_part_length to 255 which is the default storage engine value ;
1.1、 innodb is key-part-length default is 768-1; if set the innobase_large_prefix variables to ture(default is false), key-part-length can be 3072;
1.2. rocksdb's key-part-length default is 767(768-1); if set rocksdb_large_prefix variables to ture(default is false) , key-part-length can be 3072;
1.3、add a system variable tianmu_large_prefix(default values is false,and key-part-length is 767).if the system variable is true, key-part-length is 3072
2、meanwhile tianmu engine limit max_supported_key_length to 1024, while innodb is 3500.
refer to myrock5.6, the max_supported_key_length is 16* 1024, adapt this value。
Tests Check List
Changelog
Documentation