feat(StoneDB 8.0): lex->derived_tables & thd->fill_derived_tables() is deleted in MySQL8.0. (#548) #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
DandreChen
requested review from
hustjieke,
isredstar,
lujiashun and
RingsC
DandreChen
force-pushed
the
stonedb-8.0-dev
branch
from
d49ef35 to
352f099
Compare
DandreChen
changed the title
|
This pull request has merge conflicts, you should resolve it before merged. @DandreChen please update it :) Try |
DandreChen
force-pushed
the
stonedb-8.0-dev
branch
from
352f099 to
9c1cdc0
Compare
…s deleted in MySQL8.0. (stoneatom#548) [summary] 1 thd->fill_derived_tables() is deleted in 8.0, but only be used in tianmu,no other places use itin 5.7 2 lex->derived_tables is deleted in 8.0, it is used to determine whether the current query has derived_tables 3 lex->unit->derived_table means : if this query expression is underlying of a derived table, the derived table. NULL if none. 4 so we use lex->unit->derived_table instead of lex->derived_tables 5 delete the if(0) judge, so we can run the below code
DandreChen
force-pushed
the
stonedb-8.0-dev
branch
from
9c1cdc0 to
addc628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lex->derived_tables & thd->fill_derived_tables() is deleted in MySQL8.0. (#548)
Summary about this PR
Issue Number: close #issue_number_you_created
[summary]
1 thd->fill_derived_tables() is deleted in 8.0, but only be used in tianmu,no other places use itin 5.7
2 lex->derived_tables is deleted in 8.0, it is used to determine whether the current query has derived_tables
3 lex->unit->derived_table means : if this query expression is underlying of a derived table, the derived table. NULL if none.
4 so we use lex->unit->derived_table instead of lex->derived_tables
5 delete the if(0) judge, so we can run the below code
Tests Check List
Changelog
Documentation