Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StoneDB 8.0): Improve the readbility of stonedb. (#11) #832

Merged
merged 2 commits into from
Oct 28, 2022
Merged

feat(StoneDB 8.0): Improve the readbility of stonedb. (#11) #832

merged 2 commits into from
Oct 28, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Oct 27, 2022 •
edited
Loading

Summary about this PR

Issue Number: ref #11

1 class member variable refactor：compress directory;
2 class member variable refactor：types directory;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

feat(tianmu): Improve the readbility of stonedb. (stoneatom#11)
8078d7f 
[summary]
1 class member variable refactor：compress directory;
2 class member variable refactor：types directory;
@lujiashun lujiashun changed the title feat(tianmu): Improve the readbility of stonedb. (#11) feat(StoneDB 8.0): Improve the readbility of stonedb. (#11) Oct 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Oct 27, 2022
@lujiashun lujiashun marked this pull request as draft October 27, 2022 11:52
@lujiashun lujiashun self-assigned this Oct 27, 2022
@lujiashun lujiashun marked this pull request as ready for review October 27, 2022 12:51
@lujiashun lujiashun added C-stonedb-8.0 associated with stonedb 8.0 and removed C-stonedb-8.0 associated with stonedb 8.0 labels Oct 28, 2022
hustjieke
hustjieke approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DandreChen
DandreChen approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4fa57d0 into stoneatom:stonedb-8.0-dev Oct 28, 2022
@lujiashun lujiashun mentioned this pull request Nov 30, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

@DandreChen DandreChen DandreChen approved these changes

@RingsC RingsC Awaiting requested review from RingsC

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@lujiashun lujiashun

Labels
PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lujiashun @hustjieke @DandreChen