Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu):query with UNION ALL return result set error.(#854) #940

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix(tianmu):query with UNION ALL return result set error.(#854) #940

merged 2 commits into from
Nov 17, 2022

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #854

[summary]
Modify the query logic executed by the union to make the result: go through the prepare() process

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

This pull request's title should follow requirements next. @DandreChen please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@DandreChen DandreChen changed the title bugfix(tianmu):query with UNION ALL return result set error.(#854) fix(tianmu):query with UNION ALL return result set error.(#854) Nov 15, 2022
@mergify mergify bot added the PR-bug bug for pull request label Nov 15, 2022
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 2 times, most recently from 8aa5d17 to 18713dc Compare November 15, 2022 12:10
@DandreChen DandreChen marked this pull request as draft November 15, 2022 13:29
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 3 times, most recently from ccae9fa to a7993e6 Compare November 15, 2022 14:18
@DandreChen DandreChen marked this pull request as ready for review November 15, 2022 14:30
@DandreChen DandreChen self-assigned this Nov 15, 2022
RingsC
RingsC suggested changes Nov 16, 2022
View reviewed changes
RingsC
RingsC approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DandreChen
fix(tianmu):query with UNION ALL return result set error.(stoneatom#854)
67193ac 
Modify the query logic executed by the union to make the result: go through the prepare() process
hustjieke
hustjieke approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! LGTM

@mergify mergify bot merged commit 40bfcde into stoneatom:stonedb-5.7-dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke hustjieke approved these changes

@duanfuxiang0 duanfuxiang0 Awaiting requested review from duanfuxiang0

@lujiashun lujiashun Awaiting requested review from lujiashun

Assignees

@DandreChen DandreChen

Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: query with UNION ALL return result set error
3 participants
@DandreChen @RingsC @hustjieke