This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Provide file metadata in storj_finished_upload_cb, not only file id #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bridge API returns complete file metadata for uploaded files, but the storj_finished_upload_cb callback passed only the file id to libstorj clients. Thus, clients needed to execute an additional call to the bridge for retrieving metadata of interest like Created Time or HMAC. This causes unnecessary complexity and latency for clients and unnecessary load to the bridge.
|
@braydonf Note that this is a backward incompatible change for libstorj clients as the signature of the I would also appreciate a close review of the memory management as it is very easy to make it wrong. |
aleitner
reviewed
Jan 2, 2018
| STORJ_API void storj_free_uploaded_file_info(storj_file_meta_t *file) | ||
| { | ||
| if (file) { | ||
| free((char *)file->id); |
There was a problem hiding this comment.
Should we need to check if these are allocated before freeing too?
There was a problem hiding this comment.
free(NULL) is noop, isn't it? https://stackoverflow.com/a/1938758/2356099
aleitner
reviewed
Jan 2, 2018
test/tests.c
Outdated
| { | ||
| assert(handle == NULL); | ||
| if (error_code == 0) { | ||
| if (strcmp(file_id, "85fb0ed00de1196dc22e0f6d") == 0 ) { | ||
| if (strcmp(file->id, "85fb0ed00de1196dc22e0f6d") == 0 ) { |
|
We should remember to bump the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge API returns complete file metadata for uploaded files, but the
storj_finished_upload_cbcallback passed only the file id to libstorj clients. Thus, clients needed to execute an additional call to the bridge for retrieving metadata of interest like Created Time or HMAC. This causes unnecessary complexity and latency for clients and unnecessary load to the bridge.