Explicitly allow setting a null expiration date via pmpro_set_expiration_date(). #3098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
pmpro_set_expiration_date()
already works withnull
values (since$wpdb->update()
already works with them), but the PHPDocs do not reflect this. Seeing as that the alternative of zero-dates is not recommended, I think it would be good to officially support passingnull
to theenddate
parameter of this function.How to test the changes in this Pull Request:
There's not really anything to test, functionality-wise. This just makes static analysis tools like PHPStan/Psalm stop complaining when you pass
null
as theenddate
argument inpmpro_set_expiration_date()
.Other information:
Changelog entry