Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking PayFlow, PayPal Standard, and Braintree as deprecated #3184

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Sites already using these gateways can continue using them, but they will not be shown as options on new sites.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 added this to the 3.4 milestone Dec 17, 2024
@dparker1005 dparker1005 changed the base branch from dev to v3.4 January 20, 2025 19:08
@dparker1005 dparker1005 requested a review from ideadude January 20, 2025 19:08
Copy link
Member

@ideadude ideadude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready to merge.

FYI it seems we were loading the Braintree class early so the dependency checks would run even if not being used, which is okay to skip now that we are deprecating.

@ideadude ideadude merged commit 55bfb7a into strangerstudios:v3.4 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants