HTML comments visible as plain text #1326
Comments
|
Feel free to send a pull request with a fix. |
|
@FezVrasta @sapegin I want to take up this issue, however, I am unable to reproduce this issue with the mentioned version |
|
Can you look at https://github.com/quid/refraction please? You can reproduce it in that repository, you just need to comment out the manual workaround I added. I'm sorry but my home is without electricity until Monday so I can't be more helpful 😞 |
|
@FezVrasta the issue seems to be with the @sapegin This is a live demo of the dependency, for confirmation: https://probablyup.com/markdown-to-jsx/. You can confirm the issue by trying to enter any multiline HTML comment on the demo input. These look like alternatives where the above problem doesn't exist: Are there any better alternatives? |
|
@sapegin sent a PR with a test to reflect this issue |
|
Created a corresponding issue in quantizor/markdown-to-jsx#246 for this, will need follow-up |
## New features
### Support React Hooks in examples
You can now use hooks in the examples, like the `useState` hook:
```jsx
const [count, setCount] = React.useState(42);
<Button onClick={() => setCount(count + 1)}>{count}</Button>
```
(#1353 by @eragon512)
## Bug fixes
* Accessibility fixes ([#1359](#1359) by @J-Kallunki)
* `getExampleFilename` should use default example if file does not exist ([#1362](#1362)) by @mendrew, closes [#1338](#1338)
* Hide HTML comments in Markdown files ([#1347](#1347) by @eragon512, closes #1326)
|
🎉 This issue has been resolved in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Current behavior
Markdown files containing HTML comments (
<!-- ... -->) are visible as plain text since the upgrade to 9.x (9.0.5).To reproduce
Sorry I don't have time to create a repro, but it's straight forward to reproduce.
Expected behavior
The HTML comments should be hidden when rendered.
The text was updated successfully, but these errors were encountered: