feat(components): migrate Blockquote to TypeScript #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 11, 2020 08:39
feature/typescript-blockquote
feature/typescript-blockquote
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/5nd2szh43 |
Codecov Report
@@ Coverage Diff @@
## beta #617 +/- ##
==========================================
- Coverage 93.93% 93.90% -0.04%
==========================================
Files 133 133
Lines 2145 2149 +4
Branches 624 624
==========================================
+ Hits 2015 2018 +3
- Misses 106 107 +1
Partials 24 24
|
robinmetral
commented
Jun 11, 2020
robinmetral
commented
Jun 11, 2020
connor-baer
requested changes
Jun 11, 2020
feature/typescript-blockquote
added 2 commits
June 11, 2020 13:48
This makes the default size consistent with the Text component. BREAKING CHANGE: The default size for Blockquote changed from kilo to mega. feature/typescript-blockquote
feature/typescript-blockquote
feature/typescript-blockquote
feature/typescript-blockquote
connor-baer
approved these changes
Jun 11, 2020
|
🎉 This PR is included in version 2.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #516.
Purpose
Migrate the
Blockquotecomponent to TypeScript.Approach and changes
Definition of done