-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): forward custom props on all components #553
Conversation
Codecov Report
@@ Coverage Diff @@
## alpha #553 +/- ##
==========================================
- Coverage 93.09% 93.08% -0.01%
==========================================
Files 154 154
Lines 2462 2459 -3
Branches 687 691 +4
==========================================
- Hits 2292 2289 -3
Misses 139 139
Partials 31 31
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/sumup-oss/circuit-ui/g4pj60v74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOICE
@larimaza TOIT |
🎉 This PR is included in version 2.0.0-alpha.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #527.
Purpose
Functional and class components should forward any additional props to their outermost child component. This is important for
data-testid
s and custom styles using Emotion'sstyled
function.Approach and changes
Definition of done