Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handlebars decorator #102

Closed
4 tasks done
sunng87 opened this issue Sep 12, 2016 · 0 comments
Closed
4 tasks done

handlebars decorator #102

sunng87 opened this issue Sep 12, 2016 · 0 comments
Assignees
@sunng87

Comments

@sunng87
Copy link
Owner

sunng87 commented Sep 12, 2016 •
edited
Loading

Need to take a look at handlebars 4.0 decorators.

https://www.sitepoint.com/using-inline-partials-and-decorators-with-handlebars-4-0/#Decorators

  • Ability to modify data in decorator: move Context into RenderContext so it's mutable during render (e1abdf7). This change introduces a break update to HelperDef trait: Context is removed from arguments.
  • Ability to override helper definitions in decorator: add API to RenderContext for local helper (7aede0f)
  • Ability to access decorator parameters/hashes, inner template (Already implemented in partial/inline)
  • Ability to access rendered content: may not applicable to this implementation because we are using a writer instead of string concatenation. won't fix
@sunng87 sunng87 mentioned this issue Sep 13, 2016
Merged
sunng87 added a commit that referenced this issue Dec 17, 2016
@sunng87
(feat) refactor render api, put Context into RenderContext
e1abdf7 
This make Context mutable in render process, which allows decorators
to modify context.

This is part 1 on implementing #102

Signed-off-by: Ning Sun <[email protected]>
@sunng87 sunng87 self-assigned this Dec 17, 2016
@sunng87 sunng87 mentioned this issue Dec 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunng87 sunng87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunng87