-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mount correct socket on unix #3139
Conversation
Could you double check if the logs explorer works fine in studio with rootless socket? I vaguely remember analytics couldn't access the socket to read logs even though the container starts fine. |
Pull Request Test Coverage Report for Build 13300919621Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I can confirm that there are proper logs showing in the dashboard page for all of the services except for {
"code": 502,
"errors": [],
"message": "Something went wrong! Unknown error. If this continues please contact support.",
"status": "UNKNOWN"
} |
Amazing, thank you very much. When do you reckon this change will be shipped to npm? |
Once PR is merged, it will be available in beta release channel.
Stable channel will be updated in 2 weeks. |
What kind of change does this PR introduce?
This should be mounting the correct docker socket on UNIX by using
utils.Docker.DaemonHost()
instead ofclient.DefaultDockerHost
.Fixes a bug where on rootless docker, it mounts the incorrect path of
/var/run/docker.sock
instead of the correct one/run/user/1000/docker.sock
or whateverDOCKER_HOST
What is the current behaviour?
It tries to mount
/var/run/docker.sock
Please link any relevant issues here.
#3127
What is the new behaviour?
Should mount the correct path.
Additional context
It would be awesome if someone else also tests this functionality as this could introduce bugs on other systems.
PS - this pr was largely thanks to the help of @PhatDave with testing and debugging.