-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow multiple Swagger documents (no breaking changes) #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goog job until now. Please update the code as requested and let's get this merged.
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 93.29% 93.34% +0.04%
==========================================
Files 7 7
Lines 1954 1968 +14
==========================================
+ Hits 1823 1837 +14
Misses 73 73
Partials 58 58
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@h44z Thanks for your contribution! |
Describe the PR
Allow the registration of multiple Swagger documents with different names.
This PR does not contain any breaking changes as the method signature change is backwards compatible.
It basically solves the problems listed in #885.
Relation issue
To support multiple Swagger documents, the swagger router implementations have to be changed as well:
Additional context
The binary contains one optional extra parameter:
swag init --registrationName=custom_name
.This parameter can be used to override the default registration name.