Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the typing of the function #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amotzop
Copy link

@amotzop amotzop commented Feb 25, 2025

The current typing mandates that the "tapified" function must accept only one argument (of type InputType, which is anything).
The change makes it so it can accept any number of argument.

@kddubey
Copy link
Contributor

kddubey commented Mar 1, 2025

Pretty sure this is right. In fact, can we remove InputType from tapify completely?

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (f8d477c) to head (581db53).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files           4        4           
  Lines         723      723           
=======================================
  Hits          684      684           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinjm97
Copy link
Collaborator

Yes, I think that this looks reasonable. After removing InputType and adding testing (if possible), it should be ready to merge.

--Jesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants