Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/lints): Remove needless locks #10086

Merged
merged 1 commit into from
Feb 24, 2025
Merged

perf(es/lints): Remove needless locks #10086

merged 1 commit into from
Feb 24, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 24, 2025

Description:

Handler already holds mutex internally, so we don't have to do locking from linter.

@kdy1 kdy1 added this to the Planned milestone Feb 24, 2025
@kdy1 kdy1 self-assigned this Feb 24, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 24, 2025 01:39
@kdy1 kdy1 enabled auto-merge (squash) February 24, 2025 01:40
@kdy1 kdy1 disabled auto-merge February 24, 2025 01:50
@kdy1 kdy1 merged commit 43458e9 into main Feb 24, 2025
171 checks passed
@kdy1 kdy1 deleted the kdy1/lint-locks branch February 24, 2025 02:14
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #10086 will degrade performances by 3.9%

Comparing kdy1/lint-locks (55269db) with main (cf4d74a)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 188 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/lodash 191.9 ms 186.1 ms +3.13%
es/lints/libs/moment 5.7 ms 5.4 ms +3.81%
es/minifier/libs/lodash 153.5 ms 159.7 ms -3.9%

@kdy1 kdy1 modified the milestones: Planned, v1.11.1 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant