Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to napi@1 #1244

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Upgrade to napi@1 #1244

merged 1 commit into from
Dec 30, 2020

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Nov 30, 2020 •
edited by kdy1
Loading

New platforms support:

Closes #1238.
Closes #1257.
Closes #1265.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Dec 8, 2020
Closed
Closed
@Brooooooklyn
Copy link
Member Author

@kdy1 testing failed, doesn't seem to be caused by my changes.

@kdy1
Copy link
Member

kdy1 commented Dec 9, 2020

The failing test is a test about invalid config file.
It seems like napi::CallContext.get_deserialized does not support deny_unknown_fields of serde. Is this intentional?

@Brooooooklyn
Copy link
Member Author

hmmmm, seems like error was eaten by napi...I will fix it

@Brooooooklyn Brooooooklyn mentioned this pull request Dec 10, 2020
Closed
@kdy1
Copy link
Member

kdy1 commented Dec 15, 2020

Is this done?

@Brooooooklyn
Copy link
Member Author

Everything is done in swc side, I need sometime to prepare the napi@1 final release, like documentation and migration guide.

@kdy1
Copy link
Member

kdy1 commented Dec 15, 2020

Then I'll wait for it. Thanks a lot!!

@kdy1 kdy1 mentioned this pull request Dec 21, 2020
Closed
@Brooooooklyn
Upgrade to napi@1
6f45060 
- apple silicon
- linux aarch64
- linux armv7
- android aarch64
- Be compatible with yarn pnp
@Brooooooklyn Brooooooklyn marked this pull request as ready for review December 29, 2020 17:24
@Brooooooklyn
Copy link
Member Author

Ready to review

kdy1
kdy1 approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks a lot!

@kdy1 kdy1 added this to the v1.2.43 milestone Dec 30, 2020
@kdy1 kdy1 merged commit 0c45a31 into swc-project:master Dec 30, 2020
@Brooooooklyn Brooooooklyn deleted the napi-1 branch January 5, 2021 04:30
@Austaras Austaras mentioned this pull request Oct 5, 2022
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.43
Development

Successfully merging this pull request may close these issues.

Fails to load in yarn 2 PnP Support for armv7l Provide binary for android
3 participants
@Brooooooklyn @CLAassistant @kdy1